Port theme-check checks - #1259
Merged
Merged
Conversation
lukeh-shopify
approved these changes
Jul 16, 2026
Assisted-By: devx/bf1b845f-ea09-4e31-9686-5c3b1cb5ebc6
karreiro
force-pushed
the
plhp/7-changeset
branch
from
July 17, 2026 10:02
78c3220 to
c2c1c5d
Compare
karreiro
force-pushed
the
plhp/8-port-theme-checks
branch
from
July 17, 2026 10:02
5ee1a54 to
ee0ac5f
Compare
karreiro
force-pushed
the
plhp/7-changeset
branch
from
July 17, 2026 10:34
c2c1c5d to
06ab76a
Compare
karreiro
force-pushed
the
plhp/8-port-theme-checks
branch
from
July 17, 2026 10:34
ee0ac5f to
fe5bd5c
Compare
Restores completion behavior lost in the NEW liquid parser so it matches OLD across empty/unclosed slots, pipe/filter routing, literal type-narrowing, liquid-inner-statement, named-filter-arg value slots, and abutting end-tag cases (A-G, R1, R2, R3). Fix branch-tag completion parity when abutting end tag Extends the abutting-endtag recovery to LiquidBranch (elsif/when); the R3 fix covered LiquidTag/ForMarkup only.
Parser: - paginate tolerant argument parsing - comment/doc depth-balance - conditional comments - filter comma leniency - curly quotes - markdown script - nested same-name HTML tags - inline # indentation Printer: - liquid-doc trims - tablerow branched-body
karreiro
force-pushed
the
plhp/7-changeset
branch
from
July 17, 2026 11:07
06ab76a to
867a057
Compare
karreiro
force-pushed
the
plhp/8-port-theme-checks
branch
from
July 17, 2026 11:07
fe5bd5c to
8826e2d
Compare
karreiro
marked this pull request as ready for review
July 17, 2026 11:17
karreiro
force-pushed
the
plhp/8-port-theme-checks
branch
from
July 17, 2026 11:42
8826e2d to
2427db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports a set of theme-check checks into
theme-check-common.