Add changeset for hand-written liquid-html-parser#1258
Merged
Conversation
lukeh-shopify
approved these changes
Jul 14, 2026
karreiro
force-pushed
the
plhp/6-consumers
branch
from
July 16, 2026 08:56
e3196ea to
b812547
Compare
karreiro
force-pushed
the
plhp/7-changeset
branch
from
July 16, 2026 08:56
121f2fe to
23ced32
Compare
karreiro
force-pushed
the
plhp/6-consumers
branch
from
July 16, 2026 09:48
b812547 to
6c95153
Compare
karreiro
force-pushed
the
plhp/7-changeset
branch
from
July 16, 2026 09:48
23ced32 to
dc7bd69
Compare
karreiro
force-pushed
the
plhp/6-consumers
branch
from
July 16, 2026 19:25
6c95153 to
fb9232f
Compare
karreiro
force-pushed
the
plhp/7-changeset
branch
from
July 16, 2026 19:25
dc7bd69 to
87d5fa6
Compare
karreiro
force-pushed
the
plhp/6-consumers
branch
from
July 16, 2026 20:05
fb9232f to
19c15aa
Compare
karreiro
force-pushed
the
plhp/7-changeset
branch
from
July 16, 2026 20:05
87d5fa6 to
78c3220
Compare
karreiro
force-pushed
the
plhp/6-consumers
branch
from
July 17, 2026 10:02
19c15aa to
4fbc21d
Compare
karreiro
force-pushed
the
plhp/7-changeset
branch
from
July 17, 2026 10:02
78c3220 to
c2c1c5d
Compare
karreiro
force-pushed
the
plhp/6-consumers
branch
from
July 17, 2026 10:34
4fbc21d to
dfe7a36
Compare
karreiro
force-pushed
the
plhp/7-changeset
branch
from
July 17, 2026 10:34
c2c1c5d to
06ab76a
Compare
karreiro
force-pushed
the
plhp/6-consumers
branch
from
July 17, 2026 11:07
dfe7a36 to
23a149f
Compare
karreiro
force-pushed
the
plhp/7-changeset
branch
from
July 17, 2026 11:07
06ab76a to
867a057
Compare
karreiro
marked this pull request as ready for review
July 17, 2026 11:19
karreiro
added a commit
that referenced
this pull request
Jul 17, 2026
…r new parser (#1257) * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser * Restore baseline fixture output for 10 parser and printer regressions Parser: - paginate tolerant argument parsing - comment/doc depth-balance - conditional comments - filter comma leniency - curly quotes - markdown script - nested same-name HTML tags - inline # indentation Printer: - liquid-doc trims - tablerow branched-body * Add changeset for hand-written liquid-html-parser (#1258) * Remove unnecessary change
karreiro
added a commit
that referenced
this pull request
Jul 17, 2026
* Update theme-language-server-common for new parser * Fix NEW parser completion parity regressions Restores completion behavior lost in the NEW liquid parser so it matches OLD across empty/unclosed slots, pipe/filter routing, literal type-narrowing, liquid-inner-statement, named-filter-arg value slots, and abutting end-tag cases (A-G, R1, R2, R3). Fix branch-tag completion parity when abutting end tag Extends the abutting-endtag recovery to LiquidBranch (elsif/when); the R3 fix covered LiquidTag/ForMarkup only. * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser (#1257) * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser * Restore baseline fixture output for 10 parser and printer regressions Parser: - paginate tolerant argument parsing - comment/doc depth-balance - conditional comments - filter comma leniency - curly quotes - markdown script - nested same-name HTML tags - inline # indentation Printer: - liquid-doc trims - tablerow branched-body * Add changeset for hand-written liquid-html-parser (#1258) * Remove unnecessary change
karreiro
added a commit
that referenced
this pull request
Jul 17, 2026
* Add resilient liquid-html parsing * rename to tolerant * Update theme-language-server-common for new parser (#1256) * Update theme-language-server-common for new parser * Fix NEW parser completion parity regressions Restores completion behavior lost in the NEW liquid parser so it matches OLD across empty/unclosed slots, pipe/filter routing, literal type-narrowing, liquid-inner-statement, named-filter-arg value slots, and abutting end-tag cases (A-G, R1, R2, R3). Fix branch-tag completion parity when abutting end tag Extends the abutting-endtag recovery to LiquidBranch (elsif/when); the R3 fix covered LiquidTag/ForMarkup only. * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser (#1257) * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser * Restore baseline fixture output for 10 parser and printer regressions Parser: - paginate tolerant argument parsing - comment/doc depth-balance - conditional comments - filter comma leniency - curly quotes - markdown script - nested same-name HTML tags - inline # indentation Printer: - liquid-doc trims - tablerow branched-body * Add changeset for hand-written liquid-html-parser (#1258) * Remove unnecessary change
karreiro
added a commit
that referenced
this pull request
Jul 17, 2026
* Adapt liquid-html-parser to theme-tools source model * Add resilient liquid-html parsing (#1255) * Add resilient liquid-html parsing * rename to tolerant * Update theme-language-server-common for new parser (#1256) * Update theme-language-server-common for new parser * Fix NEW parser completion parity regressions Restores completion behavior lost in the NEW liquid parser so it matches OLD across empty/unclosed slots, pipe/filter routing, literal type-narrowing, liquid-inner-statement, named-filter-arg value slots, and abutting end-tag cases (A-G, R1, R2, R3). Fix branch-tag completion parity when abutting end tag Extends the abutting-endtag recovery to LiquidBranch (elsif/when); the R3 fix covered LiquidTag/ForMarkup only. * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser (#1257) * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser * Restore baseline fixture output for 10 parser and printer regressions Parser: - paginate tolerant argument parsing - comment/doc depth-balance - conditional comments - filter comma leniency - curly quotes - markdown script - nested same-name HTML tags - inline # indentation Printer: - liquid-doc trims - tablerow branched-body * Add changeset for hand-written liquid-html-parser (#1258) * Remove unnecessary change
karreiro
added a commit
that referenced
this pull request
Jul 17, 2026
* Configure liquid-html-parser package Assisted-By: devx/bf1b845f-ea09-4e31-9686-5c3b1cb5ebc6 * Adapt liquid-html-parser to theme-tools source model (#1254) * Adapt liquid-html-parser to theme-tools source model * Add resilient liquid-html parsing (#1255) * Add resilient liquid-html parsing * rename to tolerant * Update theme-language-server-common for new parser (#1256) * Update theme-language-server-common for new parser * Fix NEW parser completion parity regressions Restores completion behavior lost in the NEW liquid parser so it matches OLD across empty/unclosed slots, pipe/filter routing, literal type-narrowing, liquid-inner-statement, named-filter-arg value slots, and abutting end-tag cases (A-G, R1, R2, R3). Fix branch-tag completion parity when abutting end tag Extends the abutting-endtag recovery to LiquidBranch (elsif/when); the R3 fix covered LiquidTag/ForMarkup only. * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser (#1257) * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser * Restore baseline fixture output for 10 parser and printer regressions Parser: - paginate tolerant argument parsing - comment/doc depth-balance - conditional comments - filter comma leniency - curly quotes - markdown script - nested same-name HTML tags - inline # indentation Printer: - liquid-doc trims - tablerow branched-body * Add changeset for hand-written liquid-html-parser (#1258) * Remove unnecessary change
karreiro
added a commit
that referenced
this pull request
Jul 17, 2026
* Configure liquid-html-parser package Assisted-By: devx/bf1b845f-ea09-4e31-9686-5c3b1cb5ebc6 * Adapt liquid-html-parser to theme-tools source model * Add resilient liquid-html parsing * rename to tolerant * Update theme-language-server-common for new parser * Fix NEW parser completion parity regressions Restores completion behavior lost in the NEW liquid parser so it matches OLD across empty/unclosed slots, pipe/filter routing, literal type-narrowing, liquid-inner-statement, named-filter-arg value slots, and abutting end-tag cases (A-G, R1, R2, R3). Fix branch-tag completion parity when abutting end tag Extends the abutting-endtag recovery to LiquidBranch (elsif/when); the R3 fix covered LiquidTag/ForMarkup only. * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser * Restore baseline fixture output for 10 parser and printer regressions Parser: - paginate tolerant argument parsing - comment/doc depth-balance - conditional comments - filter comma leniency - curly quotes - markdown script - nested same-name HTML tags - inline # indentation Printer: - liquid-doc trims - tablerow branched-body * Add changeset for hand-written liquid-html-parser (#1258) * Remove unnecessary change * Copy world theme-check checks verbatim * Adapt ported theme-check checks to theme-tools--checks * Add changeset for ported theme-check checks * Regenerate factory configs for ported checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a changeset (minor bump) for the packages affected by adopting the new parser.
Part 7 of 7 in the stacked series, based on PR 6. This is the only commit that changes anything beyond the six byte-identical reorg commits.