Repository navigation
Preserve abstract signatures without runtime when translation is disabled - #1025
Merged
Merged
Conversation
vinistock
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
translate_abstract_methodsisfalse, abstract signatures should remain unchanged. Previously, the translator emitted member annotations before deciding to skip the signature, adding a stray# @without_runtimeaboveT::Sig::WithoutRuntime.sig.Filter skipped abstract signatures before generating annotations or rewriting methods. Concrete signatures continue to translate normally.
For this input:
Before: translation adds an annotation even though the signature is skipped.
After: the signature and method remain unchanged.