Repository navigation
fix(adapter): isolate re-entrancy guard by fiber - #1055
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adapter kept its re-entrancy flag on the shared instance, so concurrent calls could skip resource acquisition and circuit checks. This tracks active adapters per fiber while preserving same-fiber re-entrancy, with regression coverage and updated thread-safety guidance.\n\nVerified: targeted adapter tests (6 tests, 17 assertions), RuboCop on changed files, and
rake build. The full suite was not run; targeted tests used a minimal helper rather than the full Toxiproxy-backed setup. Closes #1045.