Repository navigation
Avoid retries and reconnects after Semian rejects access - #1054
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1051.
Protect
verify!andreconnect!before Rails can reset or close an existing connection, and exclude Semian errors from connection retries. For Rails 8.2, deliver acquisition rejections to the query intent so result access raises the original error without a second acquisition. Exception inheritance andactive?'s boolean behaviour are preserved.The shared regressions cover both adapters, open/busy rejections, synchronous retry settings, async completion and connection recovery. They fail on unchanged main (22 failures with Rails 8.1.4; 26 with Rails 8.2) and pass with this change.
Validated on Ruby 3.3/macOS with PostgreSQL 16 and MariaDB 13: 79 released-Rails adapter tests, 83 edge-Rails adapter tests, 196 common tests,
rubocopandrake build. Local runs exclude Linux bulkhead checks and one existing PostgreSQL error-class assertion, whose failure was also reproduced on unchanged main. The native Linux extension and full service-backed matrix still need CI.