Skip to content

Note in --verbose help that the extra output may include sensitive data - #8205

Draft
isaacroldan wants to merge 2 commits into
analytics-redact-shopify-envfrom
verbose-flag-sensitive-data-note
Draft

Note in --verbose help that the extra output may include sensitive data#8205
isaacroldan wants to merge 2 commits into
analytics-redact-shopify-envfrom
verbose-flag-sensitive-data-note

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Redaction of the analytics payload is best effort (see #8198, which this stacks on), so the flag that turns the payload dump on should say as much.

WHAT is this pull request doing?

One clause added to the --verbose description in public/node/cli.ts:

Increase the verbosity of the output. May include sensitive data.

The rest of the diff is regeneration. The description is embedded once per command in the manifests, the CLI README and the dev docs data, and tests-pr.yml fails if any of them are stale, so pnpm refresh-manifests and pnpm build-dev-docs account for ~520 of the lines here.

How to test your changes?

node packages/cli/bin/run.js app dev --help

The --verbose line shows the added sentence.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch) and added a changeset

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Jul 30, 2026
@isaacroldan
isaacroldan changed the base branch from analytics-redact-shopify-env to graphite-base/8205 July 31, 2026 11:37
@isaacroldan
isaacroldan force-pushed the verbose-flag-sensitive-data-note branch from 7da8e51 to c592b60 Compare July 31, 2026 11:38
@isaacroldan
isaacroldan changed the base branch from graphite-base/8205 to analytics-redact-shopify-env July 31, 2026 11:38
@isaacroldan
isaacroldan changed the base branch from analytics-redact-shopify-env to graphite-base/8205 July 31, 2026 11:41
@isaacroldan
isaacroldan force-pushed the verbose-flag-sensitive-data-note branch from c592b60 to 60924b8 Compare July 31, 2026 11:42
@isaacroldan
isaacroldan changed the base branch from graphite-base/8205 to analytics-redact-shopify-env July 31, 2026 11:42
@isaacroldan
isaacroldan changed the base branch from analytics-redact-shopify-env to graphite-base/8205 July 31, 2026 12:07
@isaacroldan
isaacroldan force-pushed the verbose-flag-sensitive-data-note branch from 298f7e7 to 6d850a6 Compare July 31, 2026 12:08
@isaacroldan
isaacroldan changed the base branch from graphite-base/8205 to analytics-redact-shopify-env July 31, 2026 12:08
@isaacroldan
isaacroldan changed the base branch from analytics-redact-shopify-env to graphite-base/8205 July 31, 2026 14:04
@isaacroldan
isaacroldan force-pushed the verbose-flag-sensitive-data-note branch from 6d850a6 to 4ce3af0 Compare July 31, 2026 14:04
@isaacroldan
isaacroldan changed the base branch from graphite-base/8205 to analytics-redact-shopify-env July 31, 2026 14:04
@isaacroldan
isaacroldan changed the base branch from analytics-redact-shopify-env to graphite-base/8205 July 31, 2026 14:54
@isaacroldan
isaacroldan force-pushed the verbose-flag-sensitive-data-note branch from 4ce3af0 to d47f121 Compare July 31, 2026 14:54
@isaacroldan
isaacroldan changed the base branch from graphite-base/8205 to analytics-redact-shopify-env July 31, 2026 14:54
@isaacroldan
isaacroldan changed the base branch from analytics-redact-shopify-env to graphite-base/8205 July 31, 2026 15:25
@isaacroldan
isaacroldan force-pushed the verbose-flag-sensitive-data-note branch from d47f121 to 512c5af Compare July 31, 2026 15:25
@isaacroldan
isaacroldan changed the base branch from graphite-base/8205 to analytics-redact-shopify-env July 31, 2026 15:25
@isaacroldan
isaacroldan changed the base branch from analytics-redact-shopify-env to graphite-base/8205 July 31, 2026 15:47
@isaacroldan
isaacroldan force-pushed the verbose-flag-sensitive-data-note branch from 512c5af to 7d3c98d Compare July 31, 2026 15:47
@isaacroldan
isaacroldan changed the base branch from graphite-base/8205 to analytics-redact-shopify-env July 31, 2026 15:47
Redaction is best effort, so the flag that turns on the payload dump should say
so. Regenerates the manifests, README and dev docs that embed the description.
@isaacroldan
isaacroldan changed the base branch from analytics-redact-shopify-env to graphite-base/8205 July 31, 2026 15:50
@isaacroldan
isaacroldan force-pushed the verbose-flag-sensitive-data-note branch from 7d3c98d to 51d7ec3 Compare July 31, 2026 15:50
@isaacroldan
isaacroldan changed the base branch from graphite-base/8205 to analytics-redact-shopify-env July 31, 2026 15:50
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Potential Breaking Changes Detected

This PR contains changes that may break the existing contract.

@shopify/dev_experience — this PR contains breaking changes that require coordination for the next major release.

🏳️ Removed Flags

The following flags were removed from existing commands:

Command Flag
store:delete --force

@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.6.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.5.0";
\ No newline at end of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant