Remove hardcoded flags#232
Merged
EmilyBourne merged 3 commits intoSciCompMod:mainfrom May 1, 2026
Merged
Conversation
mknaranja
approved these changes
Apr 27, 2026
Member
mknaranja
left a comment
There was a problem hiding this comment.
Looks good. Did you check whether psabi generates any problems? I could also be a legacy thing from version 1 or something Julian added and which is not anymore/was not necessary.
Collaborator
|
I think these flags where added by me to silence some error warnings which I found annoying. You can change them the way you like. |
Contributor
Author
I can only tell that I did not get any warning compiling with g++10. Let me know if you want me to an other test. |
Collaborator
|
@tpadioleau I can test it in a few hours when I am back home. Pretty sure you can just remove it. I don't know what it does and what it's for. 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #231. Flags from Debug mode are removed and hardcoded in the CI workflow. Flags from Release mode are removed (CMake still sets O3 by default.
ShouldThe flag-Wno-psabibe kept ?Wno-psabiis also removed.Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):