Repository navigation
Promote in-flight IndexedDB work at terminal handoff - #883
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Code OSS can begin an idle IndexedDB storage transaction before reload. WebScene retained lifecycle-descended persistence work, but realm teardown could still retire this already queued transaction, intermittently losing the workspace
mcpInputsrecord.This change routes IndexedDB compatibility tasks through a private tagged scheduler and promotes already queued IndexedDB tasks and native operations into the existing bounded terminal handoff. The public timer contract is unchanged, and unrelated timers remain outside the boundary.
The regression queues a transaction before reload, a second write from
beforeunload, and an abort frompagehide; it proves both writes and their continuation complete before handoff and remain durable after engine restart.Closes #882.
Validation
Passed on macOS arm64 Release in 0.0037 seconds. The exact Code OSS package gate follows against the merged commit.