Repository navigation
Persist before pagehide teardown - #881
Merged
Merged
Conversation
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VS Code schedules its immediate shutdown storage flush from
beforeunload, then disposes and cancels that timer frompagehide. WebScene dispatched both events synchronously, so freshly accepted MCP secrets never reached IndexedDB before reload.This splits the terminal lifecycle at the existing bounded #878 persistence boundary: veto-capable
beforeunloadremains synchronous, its zero-delay/IndexedDB lineage drains,pagehideruns once as the next browser task, and the terminal host request follows only after bounded descendants complete. Delayed timers, intervals, rAF, unrelated work, and tasks beyond the 1,024-task budget remain excluded.Closes #880.
Validation:
webscene_native_terminal_indexeddb_navigation: 1/1 passed in 1.21 secondsbeforeunload,flush-timer,commit,continuation,pagehide