Repository navigation
Flush lifecycle before top-level navigation - #874
Merged
Merged
Conversation
11 tasks
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Top-level
location.reload()and same-origin navigation reached the native host without dispatching the outgoing document lifecycle. Code OSS therefore did not receive its storage flush signal: its encrypted MCP key survived reload, while workspace-scoped MCP input metadata disappeared.Change
beforeunloadcancellation before emitting a host request.pagehidewithpersisted === falseand drain lifecycle microtasks before handoff.Progresses #269.
Validation
WEBSCENE_NATIVE_ENGINE_TEST_FILTER=top-level-navigation-lifecycle webscene_native_engine_testspassed.desktop-host-capabilitieslane continues to hit its existing Blob iframe hydration failure after this focused contract passes; that unrelated failure is outside this change.