Repository navigation
Cover Worker RPC after realm replacement - #873
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
The packaged Code OSS smoke stopped seeing Monaco's
$computeUnicodeHighlightsrequest after a top-level reload, while WebScene's prior navigation test only checked cancellation of the old Worker. This adds the missing production-shaped contract: every cycle cancels an executing pre-navigation Worker, replaces the realm, starts a named module Worker from a revoked Blob URL, imports its network module, and completes a Monaco-shaped structured-clone RPC.The reduced contract passes on current
main, so WebScene's Worker transport is not the owner of the remaining packaged Code OSS trigger failure. The dedicated CTest keeps that boundary explicit and runs 100 navigation/recreation cycles within a 20-second wall-time gate.Closes #872.
Validation
ctest --test-dir /private/tmp/webscene-872-worker-build -R '^webscene_worker_navigation_replacement_tests$' --output-on-failure