Repository navigation
Release persistent V8 handles before teardown - #852
Merged
Merged
Conversation
wieslawsoltes
changed the base branch from
fix/msvc-native-css-tests-846
to
main
September 20, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The exact Linux package gate crashes across otherwise independent V8 executables while
v8_dom_runtime::implementationis destroyed. The captured GDB stack entersGlobalHandles::NodeSpace::Releaseafter the owned isolate has already been disposed.Change
Release every previously omitted persistent-handle owner before
Isolate::Dispose():This completes the destructor's existing explicit lifetime boundary. It adds no steady-state work or storage.
Validation
v8::Globalmember and nested runtime-state owner against the destructor.git diff --checkpasses.Fixes #851