Repository navigation
Align selector invalidation trigger contracts - #845
Merged
Merged
Conversation
This was referenced Sep 20, 2026
wieslawsoltes
changed the base branch from
fix/forgiving-namespace-selector-842
to
main
September 20, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
State pseudo-class invalidation tests expected ordinary outer compounds to carry forward routes to final subjects, while the runtime compares the changed trigger first and then traverses the selector's remaining combinators. Following the test expectation broke structural selector invalidation.
Change
Align
:link,:local-link, functional local-link, and:target-withinplan assertions with the trigger-first runtime contract. Reverse routes inside relational selectors remain unchanged.Validation
webscene_selector_parser_testspasses in the focused native build.