Repository navigation
Export profile clear API from native engine - #837
Merged
Merged
Conversation
This was referenced Sep 20, 2026
wieslawsoltes
changed the base branch from
fix/details-transition-test-834
to
main
September 20, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #836.
webscene_profile_clear_data_v1was implemented inside the scene-acquisition anonymous namespace, so the V8 package compiled but consumers could not resolve the public C ABI symbol. Move only the namespace boundary so the profile clear implementation remains in the surroundingextern "C"block while the scene helpers retain internal linkage.This is stacked on #835. Validation is intentionally performed at the stack top: the exact package build must link
webscene_native_engine_tests, run the durable profile restart contract, and produce the platform package.