Skip to content

Skip empty textContent clear visual work #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wieslawsoltes merged 1 commit into from
Sep 19, 2026
Merged

Skip empty textContent clear visual work #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions experiments/WebScene.NativeEngine.Probe/native/webscene_v8_runtime_dom_properties.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,17 @@
self->commit_character_data(*node, std::move(text));
return;
}
// Empty string replacement on an already empty Element or
// DocumentFragment has no removed/added nodes and therefore no range,
// observer, lifecycle, focus, or selection effects. Style elements
// retain the existing path because CSSOM mutations can leave authored
// rule state even when their DOM child list is empty.
const auto string_replace_all = node->kind == dom_node_kind::element
|| node->kind == dom_node_kind::document_fragment;
if (string_replace_all && node->tag != "style" && text.empty()
&& node->children.empty() && node->text_content.empty()) {
return;
}
if (!self->blur_active_descendant_before_replacing_children(*node)) return;
if (node->tag == "style") {
self->erase_pending_stylesheet_replacement(node->id);
Expand Down
Loading
Loading