Repository navigation
Cache system font probes independently of GPU rendering - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated font-family checks currently call Skia's font lookup for each text preparation. Cache those positive and negative system-font probes using case-insensitive keys and a bounded 256-entry cache. Document and global web-font registrations are still checked first, so a cached missing system family cannot hide a newly registered web font.
Extracted from PR #43, commit 5547397. This PR contains only NativeTextShaping and its regression test. The cache targets the macOS system-UI metrics lookup; no separate Windows-specific optimization is introduced. The GPU-segment shaper reuse remains in #43 because its rendering path is not on main.
Validation on macOS: all 63 NativeTextShapingTests pass on .NET 8 and all 63 pass on .NET 10; git diff --check passes. The regression verifies case-insensitive cached misses, later document web-font registration, and isolation between documents. No independent performance percentage or Windows runtime qualification is claimed.