Repository navigation
Preserve navigated iframe WindowProxy messaging - #424
Merged
Merged
Conversation
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unchanged VS Code OSS browser extension host loads
webWorkerExtensionHostIframe.html?&vscodeWebWorkerExtHostId=..., rejects its bootstrap message unlessevent.source === iframe.contentWindow, and sends Worker configuration back through that stable window proxy. WebScene exposed the iframe's replaced inner Window as the message source and routed proxypostMessage()to the owner context, so the handshake stopped before Worker construction and MessagePort transfer.This change materializes the stable same-origin iframe WindowProxy before child script runs, captures it as
MessageEvent.source, and routes messages sent through it to the iframe's current inner context. The focused regression executes the fetched query-bearing iframe, module Worker creation, transferred-port identity, and round trip across 20 teardown cycles.Validation:
54fd7132Closes #421. Advances #81 and #227.