Repository navigation
Implement Node.hasChildNodes - #128
Merged
wieslawsoltes merged 0 commit intoSep 16, 2026
Merged
Conversation
wieslawsoltes
force-pushed
the
fix/node-has-child-nodes
branch
from
September 16, 2026 09:32
c36af15 to
0e76f9d
Compare
wieslawsoltes
force-pushed
the
review/code-oss-has-child-nodes-base
branch
from
September 16, 2026 09:32
61ea9d4 to
0e76f9d
Compare
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
DOMPurify reached NodeIterator and then failed because
Node.prototype.hasChildNodeswas absent.This change exposes the constant-time native child-container check through generated bindings and covers placement, receiver validation, live mutation behavior, product-neutral compatibility, and high-volume calls. The focused comparison is one commit across eight files.
Closes #84. Equivalent commit
c36af158is already in draft consolidation PR #76. This PR targets its recorded pre-fix review base for an isolated review and must remain open; do not merge it tomain.