Skip to content

Support nested CSS rules in modal layouts - #123

Merged
wieslawsoltes merged 1 commit into
mainfrom
fix/issue-112-settings-layout
Sep 16, 2026
Merged

wieslawsoltes merged 1 commit into
mainfrom
fix/issue-112-settings-layout

Conversation

@wieslawsoltes

@wieslawsoltes wieslawsoltes commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

WebScene dropped qualified CSS rules nested inside style blocks. Unchanged VS Code OSS Settings therefore lost absolute positioning, shadow, grid, and split-view constraints.

Change

  • Parse nested qualified rules, &, combinators, implicit descendants, selector lists, ordering, and media conditions.
  • Preserve nested rule output through the native stylesheet sink and NativeWeb CSS service.
  • Add parser, native layout, exact Chromium geometry, WPT-style, and bounded layout performance coverage.

Validation

  • Rebased as one focused commit on current main (4235f2f6).
  • CSS parser contract passes.
  • Focused V8 native modal/grid/split geometry matches Chromium exactly.
  • 500 positioned layouts complete in 6.079 ms against the 2,000 ms budget.
  • NativeWeb CSS service passes.
  • WPT reduction passes 1/1 documents and 4/4 subtests.
  • git diff --check passes.

Integration

Closes #112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Match absolute modal and nested Settings layout used by VS Code OSS

1 participant