Repository navigation
Cache hover selector triggers - #121
Merged
Merged
Conversation
wieslawsoltes
force-pushed
the
perf/cache-hover-selector-triggers
branch
2 times, most recently
from
September 16, 2026 10:04
e3fe37c to
103366c
Compare
wieslawsoltes
changed the base branch from
review/code-oss-hover-cache-base
to
main
September 16, 2026 10:20
wieslawsoltes
force-pushed
the
perf/cache-hover-selector-triggers
branch
from
September 16, 2026 21:58
103366c to
d04ca75
Compare
wieslawsoltes
marked this pull request as ready for review
September 16, 2026 21:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hover invalidation recompiled every dependency trigger for every changed hover-path node. The work scaled as path depth × dependency count × selector parse cost, so a 4,000-selector workload delayed publication of accepted input.
Change
hover-dependency-cachenative runner covering functional/sibling selector behavior and the deep descendant case;Validation
Focused current head
d04ca758702ced1b0e56b8368ff55c9fe0d06da6:git diff --check HEAD^ HEAD— pass;-fsyntax-onlycompile ofwebscene_v8_runtime.cppwith V8/html5ever/cssparser/Servo/generated-bindings production flags — pass;-fsyntax-onlycompile ofnative_v8_runtime_tests.cpp— pass;The current-head runner must pass
WEBSCENE_NATIVE_ENGINE_TEST_FILTER=hover-dependency-cache; that result is the authoritative changed-behavior gate. Broad package and product matrices are outside this focused parser/cache change.Integration
Closes #115.
The equivalent implementation also exists in draft consolidation PR #76. This focused PR targets
maindirectly; #76 remains open and unmerged.