Repository navigation
Dispatch finite CSS animation events - #119
Merged
Merged
Conversation
wieslawsoltes
force-pushed
the
fix/css-animation-event-lifecycle
branch
from
September 16, 2026 10:04
bf4a838 to
d38df85
Compare
wieslawsoltes
changed the base branch from
review/code-oss-animation-base
to
main
September 16, 2026 10:20
wieslawsoltes
force-pushed
the
fix/css-animation-event-lifecycle
branch
from
September 16, 2026 21:29
d38df85 to
07f8f89
Compare
wieslawsoltes
marked this pull request as ready for review
September 16, 2026 21:30
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Finite CSS keyframe animations advanced visually but did not dispatch their terminal
animationendevent. VS Code's language-status icon removes its finitewiggleclass from that event, so the missing event could retain visible frame demand after the animation completed.Change
animationendrecord withanimationName,elapsedTime,pseudoElement,bubbles, andcancelable.unique_ptr; the existing 384-bytenative_documentstatic footprint gate remains intact.Focused validation
finite-keyframe-animation-end: 25/25 focused passes.css-animation-end-class-removal.html: 1/1 document and 1/1 subtest passed against the rebuilt native engine.animation-logical-inset-isolation: 50/50 passes.git diff --check: passed.Closes #113.
Stack
Native GitHub Stack #190. Validate and merge from the cumulative top.