Brand compliance: trademark marks and HC3 product name corrections - #31
Conversation
- README.md: add ™/® marks to Scale Computing, SC//HyperCore, SC//Fleet, Ansible, and Terraform per brand guidelines; add trademark attribution footer - vm-lifecycle.ps1, iso-upload.ps1, SetTag.ps1: update credential prompt from obsolete "HC3" to "HyperCore" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- README.md: "specific Scale release" → "specific Scale Computing release" - specific_task/README.md: "against a Scale system" / "on a scale system" → "SC//HyperCore™ cluster" - platform_2025/README.md: add ™ to title to match root README - Platform2025_SnapshotExampleBash.sh: fix "Scale Compuintg" typo and expand to "Scale Computing HyperCore" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
metchason
left a comment
There was a problem hiding this comment.
Looks pretty good, left a few nit-picky comments
| [ValidateNotNullOrEmpty()] | ||
| [string] $Server, | ||
| [PSCredential] $Credential = (Get-Credential -Message "Enter Scale HC3 Credentials"), | ||
| [PSCredential] $Credential = (Get-Credential -Message "Enter SC//HyperCore Credentials"), |
There was a problem hiding this comment.
Enter SC//HyperCore virtualization suite credentials
| These scripts are only examples and demonstrate common use cases with the API. | ||
| Refer to the API docs on a scale system for a detailed guide on available calls. | ||
| These scripts are only examples and demonstrate common use cases with the API. | ||
| Refer to the API docs on a SC//HyperCore™ cluster for a detailed guide on available calls. |
There was a problem hiding this comment.
SC//HyperCore™ virtualization suite cluster
| [Parameter(mandatory=$true)] | ||
| [string]$setTag, | ||
| [PSCredential] $Cred = (Get-Credential -Message "Enter Scale HC3 Credentials") | ||
| [PSCredential] $Cred = (Get-Credential -Message "Enter SC//HyperCore Credentials") |
There was a problem hiding this comment.
"Enter SC//HyperCore virtualization suite credentials"
| @@ -1,10 +1,10 @@ | |||
| # Scale Computing Platform REST API Examples | |||
| # Scale Computing™ Platform REST API Examples | |||
There was a problem hiding this comment.
We are retiring the SC//Platform umbrella (other than the conference name). I would say "Scale Computing™ REST API Examples"
| # Scale Computing™ Platform REST API Examples | ||
|
|
||
| This repository contains several example scripts for running API queries against a HyperCore cluster or Fleet Manager. | ||
| This repository contains several example scripts for running API queries against an **SC//HyperCore™** cluster or **SC//Fleet™** platform manager. |
There was a problem hiding this comment.
SC//HyperCore™ virtualization suite cluster or SC//Fleet Manager™ edge orchestration software
| These scripts are only examples and demonstrate common use cases with the APIs. | ||
|
|
||
| Refer to this repository's tags for examples tied to a specific Scale release. | ||
| Refer to this repository's tags for examples tied to a specific Scale Computing release. |
|
|
||
| --- | ||
|
|
||
| SC//HyperCore™ and SC//Fleet™ are trademarks of Scale Computing, Inc. |
Per review on PR #31: - Drop retired "SC//Platform" umbrella from README titles - Use full product names: SC//HyperCore virtualization suite, SC//Fleet Manager edge orchestration software - Add ™ to "specific Scale Computing™ release" - Expand credential prompt text to "Enter SC//HyperCore virtualization suite credentials" Conference name "SC//Platform" retained in platform_2025/README.md per reviewer's carve-out. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Thanks for the review — all 7 comments addressed in abf124e.
Two consistency edits beyond the literal comments — both files were already in this PR's diff and each carried a string flagged elsewhere:
Deliberately left alone: One open question for you: |
taylor-leick
left a comment
There was a problem hiding this comment.
one comment, otherwise looks good
| @@ -1,9 +1,9 @@ | |||
| # Scale Computing System REST API Examples - Task Specific | |||
There was a problem hiding this comment.
probably should make the same edit as below "SC//HyperCore™ Cluster REST API Examples - Task Specific"
Updated the title to reflect the correct branding of SC//HyperCore™.
Summary
What was skipped and why
specific_task/superaudit/test_database.py:104—'model': 'HC3'is a test fixture simulating the Nodemodelfield returned by the HyperCore API. Physical HC3 appliances return "HC3" (or e.g. "HC3-2300") as their hardware model string; changing it would make the test fixture factually incorrect.Not in this PR
GitHub repo About/description field change (
REST API Examples for SC//HyperCore™ and SC//Fleet™ platform manager) — needs to be set via GitHub Settings → About.🤖 Generated with Claude Code