You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: use toast if disable-notification is set - #711
This is a different approach to what #664 solves. Uses adwaita toast if notifications are disabled. I believe this is better because it respects disable-notifications.
I must admit that I like toasts - I even prefer them in comparison to notifications as they occur where I am looking anyway.
Adding log_warn() and log_error() would allow us to automatically prepend an ⚠️ or ❌. This would make warnings and errors much more visible and the locations where errors happen easier to grep in the code. Further, I would not auto close warnings and errors. I added log_error() in #664 to set the priority to keep the notification open.
I must admit that I like toasts - I even prefer them in comparison to notifications as they occur where I am looking anyway.
Adding log_warn() and log_error() would allow us to automatically prepend an ⚠️ or ❌. This would make warnings and errors much more visible and the locations where errors happen easier to grep in the code. Further, I would not auto close warnings and errors. I added log_error() in #664 to set the priority to keep the notification open.
yes, that's a good point.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a different approach to what #664 solves. Uses adwaita toast if notifications are disabled. I believe this is better because it respects disable-notifications.