Skip to content

feat: use toast if disable-notification is set - #711

Open
RobertMueller2 wants to merge 1 commit into
Satty-org:mainfrom
RobertMueller2:toast
Open

RobertMueller2 wants to merge 1 commit into
Satty-org:mainfrom
RobertMueller2:toast

Conversation

@RobertMueller2

Copy link
Copy Markdown
Member

This is a different approach to what #664 solves. Uses adwaita toast if notifications are disabled. I believe this is better because it respects disable-notifications.

satty-20261004-182306

@robertwidfen

Copy link
Copy Markdown
Collaborator

I must admit that I like toasts - I even prefer them in comparison to notifications as they occur where I am looking anyway.

Adding log_warn() and log_error() would allow us to automatically prepend an ⚠️ or ❌. This would make warnings and errors much more visible and the locations where errors happen easier to grep in the code. Further, I would not auto close warnings and errors. I added log_error() in #664 to set the priority to keep the notification open.

@RobertMueller2

Copy link
Copy Markdown
Member Author

I must admit that I like toasts - I even prefer them in comparison to notifications as they occur where I am looking anyway.

Adding log_warn() and log_error() would allow us to automatically prepend an ⚠️ or ❌. This would make warnings and errors much more visible and the locations where errors happen easier to grep in the code. Further, I would not auto close warnings and errors. I added log_error() in #664 to set the priority to keep the notification open.

yes, that's a good point.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants