Updates header comment in truncated_octahedron.py#744
Merged
Conversation
jellybean2004
approved these changes
Jul 9, 2026
Member
|
Will be added to the release candidate. |
jellybean2004
added a commit
that referenced
this pull request
Jul 9, 2026
Updates header comment in truncated_octahedron.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #725, the model
octahedron_truncatedwas renamed totruncated_octahedron. This has led to some issues with existing SasModels & SasView builds, as set out in SasView/sasview#3993.Whilst longer term solutions should be sought, I have updated the header comment for consistency here.