Synthesize ctor_move_dtor from ctor and move_dtor when necessary.#515
Open
jemc wants to merge 2 commits intoSanderMertens:masterfrom
Open
Synthesize ctor_move_dtor from ctor and move_dtor when necessary.#515jemc wants to merge 2 commits intoSanderMertens:masterfrom
ctor_move_dtor from ctor and move_dtor when necessary.#515jemc wants to merge 2 commits intoSanderMertens:masterfrom
Conversation
jemc
force-pushed
the
lifecycle-improvements
branch
from
6fc6165 to
d9907ac
Compare
When `ctor_move_dtor` is not set, but `move` and `dtor` are set, but `move_ctor` is not set, then use `move_dtor` to synthesize it.
See this discord conversation for more background: https://discord.com/channels/633826290415435777/633826290415435781/902342988158623744
jemc
force-pushed
the
lifecycle-improvements
branch
from
d9907ac to
4a887ed
Compare
SanderMertens
force-pushed
the
master
branch
from
e5f5b80 to
bbe0c47
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
8506832 to
ef52875
Compare
SanderMertens
force-pushed
the
master
branch
from
bdff120 to
8f49fbe
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
a540dcc to
95a0110
Compare
SanderMertens
force-pushed
the
master
branch
from
e499aa8 to
a2efbef
Compare
SanderMertens
force-pushed
the
master
branch
2 times, most recently
from
6485712 to
0326782
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
07e1c0f to
5b6eef9
Compare
SanderMertens
force-pushed
the
master
branch
5 times, most recently
from
3a11369 to
e75f6f0
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
f2a3e85 to
44a171f
Compare
SanderMertens
force-pushed
the
master
branch
2 times, most recently
from
72a012f to
9e4601d
Compare
SanderMertens
force-pushed
the
master
branch
2 times, most recently
from
2c0ab43 to
5c551ae
Compare
SanderMertens
force-pushed
the
master
branch
2 times, most recently
from
f277e75 to
61076ac
Compare
SanderMertens
force-pushed
the
master
branch
2 times, most recently
from
0b0631f to
c4b01f9
Compare
SanderMertens
force-pushed
the
master
branch
from
60a3a11 to
a016e60
Compare
SanderMertens
force-pushed
the
master
branch
from
d99efe2 to
da0221e
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
438bde4 to
220852f
Compare
SanderMertens
force-pushed
the
master
branch
3 times, most recently
from
3b99938 to
ac6cdca
Compare
SanderMertens
force-pushed
the
master
branch
from
7874ea5 to
f479787
Compare
SanderMertens
force-pushed
the
master
branch
4 times, most recently
from
fc7d291 to
46c275d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ctor_move_dtoris not set, butmoveanddtorare set,but
move_ctoris not set, then usemove_dtorto synthesize it.