Repository navigation
client: admit only real session creation - #1
Closed
Piggy-Cat-bit-shadow wants to merge 1 commit into
Closed
Piggy-Cat-bit-shadow wants to merge 1 commit into
Piggy-Cat-bit-shadow wants to merge 1 commit into
Conversation
DialContext first tries to reuse an idle session and only then creates one. These two paths have different costs: a reuse opens one stream, a creation pays a TCP connect, a TLS handshake and the first write. A caller that bounds creation had to wrap DialContext, so a healthy reuse waited behind creations it was not part of. Add ClientOptions.AdmitCreation. It is called exactly once per new session, after the reuse attempt failed, and owns the call: it must invoke create exactly once and return its error, so a refusal means no dial happens and the actual creation error is what the caller's outcome accounting sees. A nil hook keeps the previous behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DialContext first tries to reuse an idle session and only then creates one. The two paths have different costs: a reuse opens one stream, while a creation pays a TCP connect, a TLS handshake and the first write. A caller that bounds session creation had to wrap DialContext, so a healthy reuse waited behind creations it was not part of.