fix(loader): incorect text size for loading text inside buttons#8035
Merged
Conversation
tomdavies73
reviewed
Jun 22, 2026
| /** Enable the error state for the ring loader when it is tracked */ | ||
| isError?: boolean; | ||
| /** Specify if the loader is inside a button */ | ||
| isInsideButton?: boolean; |
Contributor
There was a problem hiding this comment.
question: is this something we want to surface on the public API for the component?
Could we not instead create/use some sort of internal context which will set this to true internally without any consumer input
tomdavies73
approved these changes
Jun 25, 2026
nuria1110
approved these changes
Jul 3, 2026
paulrobinson88
approved these changes
Jul 6, 2026
Collaborator
|
🎉 This PR is included in version 161.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
This PR fixes the Loader text size when it's used inside Button components.
ButtonContextin order to be able to determine if the Loader is inside a button or not.isInsideButton.Current behaviour
When the loader is used inside a button the incorrect font size is used.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions