GSE-226: Fix local footer lockup override for stanford_basic SDC refactor (7.0.0) - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GSE-226: DEV | Refactor gse_subtheme for Stanford Sites SDC and stanford_profile 13.x compatibility
config-pages--stanford-local-footer.html.twigstopped reading its lockup variables from preprocess. Fixed by renaming the preprocess hook (hook_preprocess_pattern_localfooter()→hook_preprocess_config_pages__stanford_local_footer()) and adding a template override (templates/config-pages--stanford-local-footer.html.twig) that feeds the lockup values from that hook instead of the site'sconfig_pagesfields. Also fixes a pre-existing bug wherelockup_optionwas double-prefixed (su-lockup--option-su-lockup--option-none) and never matched any CSS class. Additionally bumps the theme version to semver (1.0.0), removes the one-timerename_theme.shsetup script, and documents the theme's customizations in the README.Review By (Date)
Criticality
Urgency
Review Tasks
Setup tasks and/or behavior to test
drush cr ; drush ci/admin/config/system/local-footerBackend / Functional Validation
Code
preprocess_config_pages__stanford_local_footer,use_default_logo).config-pages--stanford-local-footer.html.twig, not just the lockup-related lines, because the upstream template usesinclude()rather thanembed()with overridable blocks, so there's no smaller seam available. See README's Customizations section for the maintenance note.General
gse_subtheme.info.ymlversion to semver (1.0.0), removing the now-unneededrename_theme.shsetup script, and documenting theme customizations in the README.Associated Issues and/or People