Skip to content

GSE-226: Fix local footer lockup override for stanford_basic SDC refactor (7.0.0) - #15

Merged
joegl merged 2 commits into
1.xfrom
GSE-226--refactor-7.0.0
Sep 22, 2026
Merged

joegl merged 2 commits into
1.xfrom
GSE-226--refactor-7.0.0

Conversation

@joegl

@joegl joegl commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

GSE-226: DEV | Refactor gse_subtheme for Stanford Sites SDC and stanford_profile 13.x compatibility

  • Restores the GSE local footer logo-only lockup, which broke after Stanford Sites moved the local footer to a Single Directory Component (SDC) and stanford_profile's config-pages--stanford-local-footer.html.twig stopped reading its lockup variables from preprocess. Fixed by renaming the preprocess hook (hook_preprocess_pattern_localfooter() → hook_preprocess_config_pages__stanford_local_footer()) and adding a template override (templates/config-pages--stanford-local-footer.html.twig) that feeds the lockup values from that hook instead of the site's config_pages fields. Also fixes a pre-existing bug where lockup_option was double-prefixed (su-lockup--option-su-lockup--option-none) and never matched any CSS class. Additionally bumps the theme version to semver (1.0.0), removes the one-time rename_theme.sh setup script, and documents the theme's customizations in the README.

Review By (Date)

  • TBD

Criticality

  • 4/10

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to any page and scroll to the local footer
  4. Verify the local footer shows the GSE logo-only lockup ("Stanford Graduate School of Education" with the GSE logo image), regardless of what's configured on /admin/config/system/local-footer

Backend / Functional Validation

Code

  • Are the naming conventions following our standards? Hook and variable names follow the naming stanford_basic 7.x now uses (preprocess_config_pages__stanford_local_footer, use_default_logo).
  • Does the code have sufficient inline comments? Preprocess hook and template override both document why the override exists and what to do if stanford_basic changes the upstream template.
  • Are there any code smells? The template override duplicates all of stanford_basic's config-pages--stanford-local-footer.html.twig, not just the lockup-related lines, because the upstream template uses include() rather than embed() with overridable blocks, so there's no smaller seam available. See README's Customizations section for the maintenance note.

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve? Yes, three small unrelated cleanups bundled in: bumping gse_subtheme.info.yml version to semver (1.0.0), removing the now-unneeded rename_theme.sh setup script, and documenting theme customizations in the README.
  • Is the approach to the problem appropriate? Yes — matches the pattern used in the reference fix (first_step_subtheme#22).

Associated Issues and/or People

  • GSE-226: DEV | Refactor gse_subtheme for Stanford Sites SDC and stanford_profile 13.x compatibility
  • Reference fix: first_step_subtheme#22 ("refactor local footer for 7.0.0 release")

@joegl joegl changed the title Override lockup values for 7.x with template override. GSE-226: Fix local footer lockup override for stanford_basic SDC refactor (7.0.0) Aug 26, 2026
@joegl
joegl merged commit aeeeb44 into 1.x Sep 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant