adr: gradual consumer migration from services to jobs#19
Conversation
|
Warning Review limit reached
More reviews will be available in 59 minutes and 58 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label add-to-gt-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
11a7a94 to
bf2e0a4
Compare
3922ec6 to
7192363
Compare
bf2e0a4 to
9dc82da
Compare
7192363 to
5b9e6a8
Compare
9dc82da to
834f710
Compare
5b9e6a8 to
0366f23
Compare
834f710 to
5843a37
Compare
0366f23 to
39780cf
Compare
5843a37 to
fd55c0f
Compare
39780cf to
8f4f05a
Compare
9184207 to
2ef55ed
Compare
2ef55ed to
772cdd2
Compare
772cdd2 to
acac499
Compare
1760f55 to
6cc8e9f
Compare
6cc8e9f to
f2752ab
Compare
acac499 to
a656523
Compare
f2752ab to
9947e4e
Compare
a656523 to
5e24f05
Compare
9947e4e to
9d1a600
Compare
5e24f05 to
7002bce
Compare
7002bce to
ef0e37d
Compare
9d1a600 to
95a21bd
Compare
95a21bd to
3cfa702
Compare
ef0e37d to
79a8e1a
Compare
| request -> job -> outcome shape. The shared equity-transfer module precedes the | ||
| four aggregates that consume `EquityTransferServices`, so they don't grow four | ||
| divergent copies of the same SDK wrappers. The recoveries go last among |
There was a problem hiding this comment.
The text states "four aggregates that consume EquityTransferServices" but the table on lines 24-30 shows only two aggregates actually use EquityTransferServices: TokenizedEquityMint (line 27) and EquityRedemption (line 28). UnwrappedEquityRecovery uses UnwrappedEquityRecoveryServices and WrappedEquityRecovery uses WrappedEquityRecoveryServices. This count mismatch will confuse readers about which aggregates depend on the shared equity-transfer module.
# Should be changed to:
The shared equity-transfer module precedes the two aggregates that consume `EquityTransferServices`, so they don't grow divergent copies of the same SDK wrappers.| request -> job -> outcome shape. The shared equity-transfer module precedes the | |
| four aggregates that consume `EquityTransferServices`, so they don't grow four | |
| divergent copies of the same SDK wrappers. The recoveries go last among | |
| request -> job -> outcome shape. The shared equity-transfer module precedes the | |
| two aggregates that consume `EquityTransferServices`, so they don't grow | |
| divergent copies of the same SDK wrappers. The recoveries go last among | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
3cfa702 to
ec562c0
Compare
79a8e1a to
3016cb6
Compare
3016cb6 to
8c7c6f7
Compare
ec562c0 to
2d6d324
Compare

Motivation
ADR-0001 removes
EventSourced::Services, so consumers need a reviewable path from inline command-handler side effects to durable jobs before they can take the breaking jobs API.st0x.liquidityhas 10EventSourcedimpls,st0x.issuancehas 5, and issuance has an in-flight EventSourced migration that must not be disturbed.Closes RAI-923.
Solution
conductor::jobmachinery and more aggregates exercising the pattern.