[codex] Surface merchant application submit failures#136
Draft
SanchezOLeary wants to merge 3 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/locationsactually returns201.LocationProvider.addLocation()back to the form.payment_wallets: []in the create payload so the touched form matches the existingAuthedLocationtype.active = TRUE AND google_id IS NOT NULL.Why
The Sheba place data is being found and populated correctly, but
/locationsis returning400. The confirmed backend error is Postgres rejecting the upsert because there is no unique/exclusion constraint matching theON CONFLICTtarget.The schema creates a partial unique index on
locations(google_id)only whereactive = TRUE AND google_id IS NOT NULL, but the save query was targeting onlyactive = TRUE. Postgres requires the conflict target to match an eligible unique/exclusion constraint or index, so the insert failed before any pending merchant application could be created.Validation
git diff --checkcd backend && go test -vet=off ./db ./handlerscd frontend && npx tsc --noEmit --pretty falsestill fails only on existing unrelated role-management/mock merchant type errors; no errors remain in the touched merchant application form.