evolution#1027
Open
etbe wants to merge 3 commits into
Open
Conversation
Signed-off-by: Russell Coker <russell@coker.com.au>
…s for gkeyringd Signed-off-by: Russell Coker <russell@coker.com.au>
pebenito
requested changes
Sep 25, 2025
| ') | ||
|
|
||
| optional_policy(` | ||
| wm_send_fd(evolution_alarm_t) |
Member
There was a problem hiding this comment.
Do you know what this fd is used for?
Also, with the added wm call on line 335 (new line num), the wm module is already unconditionally required. Please make both lines uncondtional or optional.
Contributor
Author
There was a problem hiding this comment.
I made them all optional. Not sure about the use of the fd.
Member
There was a problem hiding this comment.
Is there an error message in the regular log (not audit messages)? If not, how does the code functionally fail?
Signed-off-by: Russell Coker <russell@coker.com.au>
Contributor
Author
|
@pebenito Is anything else needed for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.