Add cxx_std_11 CMake compile feature to PCU#533
Merged
Conversation
std::unique_ptr was introduced in C++11 and required for the new public PCU interface.
Collaborator
Author
|
@cwsmith, we ran into errors when building a project that links against PUMI with a compiler that didn't default to C++11. We were using |
Contributor
|
/runtests |
|
Build Log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cxx_std_11 feature to PCU
std::unique_ptrwas introduced in C++11 and is used by the new public PCU interface.When the C++ standard is not set with
CMAKE_CXX_STANDARDand does not default to at least C++11 for the selected compiler, errors are emitted when other projects try to link against PUMI. The default build behavior should be successful.This change allows the C++11 requirement to propagate to targets that link against
pcu. The default PUMI C++ standard is already C++11:core/CMakeLists.txt
Lines 28 to 37 in 395d3a2
This change propagates that setting outward for at least the
pculibrary (which thecorelinks against, and so the library as a whole getscxx_std_11as aPUBLICfeature).