Repository navigation
chacha20: use cargo hack in CI - #458
Merged
Merged
Conversation
tarcieri
force-pushed
the
chacha20/use-cargo-hack-in-ci
branch
from
September 8, 2025 20:36
ac639dd to
f81d2da
Compare
Member
|
Maybe it's worth to remove |
To prevent bugs like #454 in the future, exhastively check all feature combinations to ensure they all work correctly Additionally, this adds the needed feature gating so the crate passes tests with `--no-default-features`
tarcieri
force-pushed
the
chacha20/use-cargo-hack-in-ci
branch
from
September 8, 2025 20:41
f81d2da to
f90219e
Compare
Member
Author
|
@newpavlov something to think about. We could also just get rid of the feature-gating and otherwise leave them as-is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent bugs like #454 in the future, exhastively check all feature combinations to ensure they all work correctly