WASAPI: Prefer "friendly name" in device description#1153
Merged
roderickvd merged 4 commits intoRustAudio:masterfrom Apr 13, 2026
Merged
WASAPI: Prefer "friendly name" in device description#1153roderickvd merged 4 commits intoRustAudio:masterfrom
roderickvd merged 4 commits intoRustAudio:masterfrom
Conversation
roderickvd
reviewed
Apr 12, 2026
Member
roderickvd
left a comment
roderickvd
left a comment
There was a problem hiding this comment.
Yes, you're right. If you could check out this one tiny thing? I may be wrong when clippy hasn't triggered on it before.
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes common issue where users have multiple devices named "Speakers". The friendly name is the same one as displayed in the OS output selection.
I opted to remove the extended line since it doesn't really add anything now.