Skip to content

[Improve] List Discord Add Reactions as a required install permission#513

Merged
mrubens merged 2 commits into
developfrom
improve/discord-add-reactions-permissions-docs-2vmheap85iqxy
Jul 18, 2026
Merged

[Improve] List Discord Add Reactions as a required install permission#513
mrubens merged 2 commits into
developfrom
improve/discord-add-reactions-permissions-docs-2vmheap85iqxy

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Discord.

What changed

Discord bot setup copy and public docs list Add Reactions as a required installation permission. Channel diagnostics now enforce the same: add_reactions is part of requiredPermissions, so a channel without that permission is reported unusable (canUseChannel: false).

Why this change was made

Operators were getting soft optional reaction-permission guidance while install requested Add Reactions, and diagnostics still accepted reaction-denied channels as usable. Review feedback asked to align enforcement with the required-permission wording.

Impact

  • Setup/docs and install permissions language match runtime channel checks
  • Selecting a default Discord channel (or other diagnose-backed flows) fails closed when Add Reactions is missing
  • Denied reaction permission surfaces as missingPermissions: ['add_reactions']

Screenshots

Discord installation permissions list includes Add Reactions

List Add Reactions as a required install permission in setup copy and docs
instead of soft-pedaling it as optional acknowledgements-only.
@roomote-roomote

roomote-roomote Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

No new code issues found. See task

  • apps/docs/providers/communications/discord.mdx:43-50 and apps/web/src/app/(onboarding)/setup/ProviderSetupInstructions.tsx:169-172 — The new copy says Add Reactions is required, but effective channel diagnostics omit add_reactions from requiredPermissions; a denied reaction permission is still accepted as usable. Either enforce it in the diagnostics or keep the acknowledgment-only wording so setup guidance matches behavior.

Reviewed a20f3d1

@roomote-roomote

roomote-roomote Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the outstanding review item: add_reactions is now required in Discord channel diagnostics (canUseChannel fails when it is denied).

Commit: a20f3d1

Treat Add Reactions as required for canUseChannel so setup guidance
matches channel permission diagnostics.
@mrubens
mrubens marked this pull request as ready for review July 18, 2026 01:53
@mrubens
mrubens merged commit 2d7f7a6 into develop Jul 18, 2026
17 checks passed
@mrubens
mrubens deleted the improve/discord-add-reactions-permissions-docs-2vmheap85iqxy branch July 18, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant