[Chore] Drop unused Xvfb from the worker image#395
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
Conversation
Remove the leftover Xvfb package after the headed desktop stack was retired, and bump the worker runtime schema so images rebuild.
Contributor
Author
|
1 issue outstanding. See task
Reviewed 207ec0e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal worker image cleanup after retiring the headed desktop/VNC stack. No linked issue.
Why this PR exists
What changed
Audited the worker image after VNC/desktop removal. KasmVNC, XFCE, and related desktop packages were already gone. This change drops the remaining unused
xvfbpackage fromapps/worker/Dockerfile, locks that absence into the existing desktop-runtime regression test, and bumps the worker runtime schema version so cacheable images rebuild.Intentionally kept:
agent-browserDISPLAYenv passthrough (still an allowlisted runtime env var)/sandbox/.vscodeas a legacy provider/snapshot path identifier/websockifyroutes (preview WebSocket protocol, not a VNC server)How it was tested
pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/compute-providers exec vitest run src/adapters/modal.test.ts(31 passed)check-types:fast, knipChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset