Skip to content

fix: culture info for vector passes #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jooty wants to merge 1 commit into
base: quality-assurance
Choose a base branch
from
Open

fix: culture info for vector passes #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/Imlight.CoreLib/Shared/Resources/Util.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,27 +18,32 @@

using Imcodec.Math;
using System;
using System.Globalization;

namespace Imlight.CoreLib.Shared.Resources;

internal static class Util {

public static string GetCompactStringFromVector(Vector4 vector)
=> $"{vector.X},{vector.Y},{vector.Z},{vector.W}";
public static string GetCompactStringFromVector(Vector4 vector) {
var inv = System.Globalization.CultureInfo.InvariantCulture;
return $"{vector.X.ToString(inv)},{vector.Y.ToString(inv)},{vector.Z.ToString(inv)},{vector.W.ToString(inv)}";
}

public static string GetCompactStringFromVector(Vector3 vector, Vector3 orientation)
=> $"{vector.X},{vector.Y},{vector.Z},{orientation.Z}";
public static string GetCompactStringFromVector(Vector3 vector, Vector3 orientation) {
var inv = System.Globalization.CultureInfo.InvariantCulture;
return $"{vector.X.ToString(inv)},{vector.Y.ToString(inv)},{vector.Z.ToString(inv)},{orientation.Z.ToString(inv)}";
}

public static Vector4 GetVectorFromCompactString(string loc) {
if (loc.Split(',').Length != 4) {
return Vector4.Zero;
}

var components = loc.Split(",");
var x = float.TryParse(components[0], out var xVal) ? xVal : 0;
var y = float.TryParse(components[1], out var yVal) ? yVal : 0;
var z = float.TryParse(components[2], out var zVal) ? zVal : 0;
var d = float.TryParse(components[3], out var dVal) ? dVal : 0;
var x = float.TryParse(components[0], NumberStyles.Float, CultureInfo.InvariantCulture, out var xVal) ? xVal : 0;
var y = float.TryParse(components[1], NumberStyles.Float, CultureInfo.InvariantCulture, out var yVal) ? yVal : 0;
var z = float.TryParse(components[2], NumberStyles.Float, CultureInfo.InvariantCulture, out var zVal) ? zVal : 0;
var d = float.TryParse(components[3], NumberStyles.Float, CultureInfo.InvariantCulture, out var dVal) ? dVal : 0;

return new Vector4(x, y, z, d);
}
Expand Down