Skip to content

Update general license from CC to MIT for website code and setup proper carve outs for third party code and assets - #33

Merged
Arctis-Fireblight merged 1 commit into
Redot-Engine:masterfrom
Arctis-Fireblight:relicense
Sep 13, 2026
Merged

Arctis-Fireblight merged 1 commit into
Redot-Engine:masterfrom
Arctis-Fireblight:relicense

Conversation

@Arctis-Fireblight

@Arctis-Fireblight Arctis-Fireblight commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator
  • Added /licenses page detailing website, documentation, and media licenses.
  • Introduced MEDIA-LICENSES.txt for media-specific licensing notices.
  • Updated attribution references across documentation and components.
  • Enhanced documentation tests to validate license attribution handling.
  • Updated license file to replace CC BY 3.0 with MIT for relevant assets.

Note: While prior versions of this site may have had minor mistakes in licensing verbiage, non-third party content prior to this commit and PR still remain available under the original CC BY 3.0 terms. Creative Commons licenses are irrevocable and perpetual. The MIT terms only apply to covered portions of the repo from this commit onwards.

Commits beyond this point are governed by the new licensing terms, not the old.

Summary by CodeRabbit

  • New Features

    • Added a /licenses page with comprehensive licensing and attribution information.
    • Documentation pages now display relevant attribution notices, including separate notices for the manual and class reference.
    • Added accessible license and third-party notice files for the website, documentation, media, dependencies, and engine materials.
  • Documentation

    • Clarified licensing boundaries for website code, documentation, class references, media, and contributions.
    • Updated README and contribution guidance with links to detailed licensing information.
  • Tests

    • Added coverage verifying attribution notices on manual and class-reference pages.

…er carve outs for third party code and assets

- Added `/licenses` page detailing website, documentation, and media licenses.
- Introduced `MEDIA-LICENSES.txt` for media-specific licensing notices.
- Updated attribution references across documentation and components.
- Enhanced documentation tests to validate license attribution handling.
- Updated license file to replace CC BY 3.0 with MIT for relevant assets.

Note: While prior versions of this site may have had minor mistakes in licensing verbiage, non-third party content prior to this commit and PR still remain available under the original CC BY 3.0 terms. Creative Commons licenses are irrevocable and perpetual. The MIT terms only apply to covered portions of the repo from this commit onwards.

Commits beyond this point are governed by the new licensing terms, not the old.
@Arctis-Fireblight Arctis-Fireblight self-assigned this Sep 13, 2026
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b7169e1c-6fca-448c-b7fc-8ae1a96d34c6

📥 Commits

Reviewing files that changed from the base of the PR and between 2461c63 and 80042ed.

📒 Files selected for processing (22)
  • LICENSE.txt
  • LICENSING.md
  • README.md
  • Redot-Documentation-Tests/ClassDocumentationComponentTests.cs
  • Redot-Documentation/Components/Layout/DocumentationAttribution.razor
  • Redot-Documentation/Components/Pages/ClassDocViewer.razor
  • Redot-Documentation/Components/Pages/DocViewer.razor
  • Redot-Documentation/Components/Pages/Licenses.razor
  • Redot-Documentation/Redot-Documentation.csproj
  • Redot-Documentation/docs/About/faq.md
  • Redot-Documentation/docs/About/introduction.md
  • Redot-Documentation/docs/Contributing/Documentation/contributing_to_the_documentation.md
  • Redot-Documentation/docs/LICENSE.txt
  • Redot-Documentation/wwwroot/MEDIA-LICENSES.txt
  • Redot-Documentation/wwwroot/app.css
  • Redot-Documentation/wwwroot/lib/bootstrap/LICENSE.txt
  • Redot-Documentation/wwwroot/lib/prism/LICENSE.txt
  • Redot-Documentation/wwwroot/licenses/ASPNETCORE-THIRD-PARTY-NOTICES.txt
  • Redot-Documentation/wwwroot/licenses/DOTNET-MIT.txt
  • Redot-Documentation/wwwroot/licenses/DOTNET-THIRD-PARTY-NOTICES.txt
  • Redot-Documentation/wwwroot/licenses/MARKDIG-BSD-2-CLAUSE.txt
  • Redot-Documentation/wwwroot/licenses/REDOT-ENGINE-MIT.txt

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change separates licensing scopes for the website, documentation, class reference, media, and dependencies. It adds site attribution notices, a licenses page, published license files, updated documentation, and rendering tests.

Changes

Licensing and attribution

Layer / File(s) Summary
Licensing policy and source notices
LICENSE.txt, LICENSING.md, README.md, Redot-Documentation/docs/About/*, Redot-Documentation/docs/Contributing/Documentation/*, Redot-Documentation/docs/LICENSE.txt, Redot-Documentation/wwwroot/MEDIA-LICENSES.txt
The repository now defines separate MIT, CC BY 3.0, upstream class-reference, media, and third-party licensing scopes.
Site attribution rendering and validation
Redot-Documentation/Components/Layout/DocumentationAttribution.razor, Redot-Documentation/Components/Pages/*, Redot-Documentation/wwwroot/app.css, Redot-Documentation-Tests/ClassDocumentationComponentTests.cs
Documentation and class-reference pages render distinct attribution notices. A /licenses page and attribution styling were added. Tests verify both rendered notices.
Published license and dependency notices
Redot-Documentation/Redot-Documentation.csproj, Redot-Documentation/wwwroot/lib/*/LICENSE.txt, Redot-Documentation/wwwroot/licenses/*
License and author files are copied into site output. License texts and third-party notices for bundled libraries, ASP.NET Core, .NET, Markdig, and the engine are included.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 80042

The licensing notices and attribution links are wired for publication, with no confirmed merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (21 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: moving applicable website code from CC BY 3.0 to MIT and defining carve-outs for third-party code and assets.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (21 skipped: 21 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Arctis-Fireblight
Arctis-Fireblight merged commit deb209f into Redot-Engine:master Sep 13, 2026
4 checks passed
@Arctis-Fireblight
Arctis-Fireblight deleted the relicense branch September 13, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant