Skip to content

Add CLEAN and EXTRA_MYSQL/EXTRA_POSTGRESQL options#79

Open
julien-noblet wants to merge 4 commits into
RealOrangeOne:masterfrom
julien-noblet:feat/add_clean_options
Open

Add CLEAN and EXTRA_MYSQL/EXTRA_POSTGRESQL options#79
julien-noblet wants to merge 4 commits into
RealOrangeOne:masterfrom
julien-noblet:feat/add_clean_options

Conversation

@julien-noblet

Copy link
Copy Markdown
Contributor

Add a CLEAN option to add DROP before database and tables creations.

Also add EXTRA_ parameters to fine tuning dumps!

@RealOrangeOne

Copy link
Copy Markdown
Owner

In the case of a backup, is clean helpful? I'd expect it to be restored into a clean DB?

With that said, the code change is small, so I'm not opposed to adding it. That said, it'd be great to see some tests for this.

@julien-noblet

Copy link
Copy Markdown
Contributor Author

Yes, I'm trying to make it easier to restore into a fresh container...
I've seen I made some mistakes on my code...

Let me try to fix it, and put some extra tests.

@julien-noblet

Copy link
Copy Markdown
Contributor Author

Tests are passing now 🍾
@RealOrangeOne can you review my code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants