dfs/romfs: validate ioctl args for RT_FIOGETADDR#11353
dfs/romfs: validate ioctl args for RT_FIOGETADDR#11353Aphlita wants to merge 3 commits intoRT-Thread:masterfrom
Conversation
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2026-04-30 21:43 CST)
📝 Review Instructions
|
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
dfs_romfs_ioctl()在处理RT_FIOGETADDR命令时会直接解引用args。如果调用方传入空指针,DFS v1/v2的romfs实现会在错误路径上触发空指针解引用,而不是稳定返回错误码。你的解决方案是什么 (what is your solution)
在DFS v1和DFS v2的romfs
RT_FIOGETADDR分支中增加args == RT_NULL检查。当调用方传入空指针时返回-RT_EINVAL,避免空指针解引用。该修改只影响
RT_FIOGETADDR的异常输入路径,不改变正常传入有效输出参数时的行为,也不影响RT_FIOFTRUNCATE等其他ioctl命令。请提供验证的bsp和config (provide the config and bsp)
bsp/simulatorbsp/simulator当前默认配置,无需额外修改本地验证:
git diff --check -- components/dfs/dfs_v1/filesystems/romfs/dfs_romfs.c components/dfs/dfs_v2/filesystems/romfs/dfs_romfs.cscons -C /home/world/rt-thread/bsp/simulator -j2cppcheck --enable=warning,style,performance,portability --quiet components/dfs/dfs_v1/filesystems/romfs/dfs_romfs.c components/dfs/dfs_v2/filesystems/romfs/dfs_romfs.c说明:
cppcheck仅报告romfs文件中既有style提示,未发现本次新增空指针校验相关问题。]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up