Repository navigation
chore: qnexus runtime traces tests - #400
Merged
Merged
Conversation
added 2 commits
November 9, 2026 10:34
gsangiolo
reviewed
Nov 9, 2026
gsangiolo
reviewed
Nov 9, 2026
added 2 commits
November 9, 2026 18:33
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the runtime-trace integration tests, which are currently skipped pending QA deployment of trace support.
No open issues 🎉
What changed in this PR
Adds integration tests for runtime trace downloads through the qnexus client using Helios emulators. The tests are currently skipped pending deployment of runtime trace support to QA.
Changes:
- Adds QIR and HUGR trace-download tests that validate trace events and sources.
- Adds a test expecting a 404 when downloading traces for an unknown job item.
- Introduces a shared Helios-1E emulator configuration fixture.
| File | Description |
|---|---|
integration/test_runtime_traces.py |
Adds trace-download, validation, and unknown-item error tests, currently skipped. |
integration/conftest.py |
Adds the shared Helios emulator configuration fixture. |
Review effort: Balanced
gsangiolo
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added integration tests for runtime traces.
PS: I noticed a case where i got a 404 after
has_runtime_traceswas already set to true - I am trying to reproduce that.