feat: implement signer domain separation v2

[charliechinedu19-netizen]

Summary

Closes #571

Hardens signature verification by introducing a canonical signed payload envelope that includes contract ID, network passphrase, and action type, preventing replay across methods, contracts, and networks.

---

What Changed

1. Canonical Signed Payload Envelope (nonce.rs)

Off-chain signers now construct payloads as:

payload = concat(
    "QUICKEX::SIGNED_PAYLOAD::v2"    // domain tag (28 bytes)
    || be32(len(contract_id_xdr))    // contract binding
    || contract_id_xdr
    || be32(len(network_passphrase)) // network binding
    || network_passphrase
    || be32(len(action_type))        // method binding
    || action_type_bytes             // e.g. "WITHDRAW"
    || be64(nonce)
    || be64(valid_until)
)
signed_hash = SHA256(payload)

New exports:

• build_canonical_payload() — builds the full envelope
• hash_canonical_payload() — returns the SHA256 to sign
• domain_prefix_v1() — legacy helper retained for migration

2. ActionType Enum (nonce.rs)

14 variants covering every contract entry point that requires authorization:
Withdraw, Refund, Dispute, ResolveDispute, VoteForDispute, ResolveDisputeMultiSig, Deposit, DepositWithCommitment, DepositPartial, PartialPayment, StealthDeposit, StealthWithdraw, SetPrivacy, Upgrade

Each variant maps to a unique byte tag used in the canonical envelope.

3. Nonce Verification Wired into Contract Methods

Every signature-based action now accepts nonce: u64, valid_until: u64 and calls nonce::verify_and_consume() with the appropriate ActionType:

Method	ActionType
deposit	Deposit
deposit_with_commitment	DepositWithCommitment
deposit_partial	DepositPartial
withdraw	Withdraw
refund	Refund
partial_payment	PartialPayment
resolve_dispute	ResolveDispute
vote_for_dispute	VoteForDispute
register_ephemeral_key	StealthDeposit
stealth_withdraw	StealthWithdraw

4. Nonce Storage Layout

NonceKey::Used(Address, u64, ActionType) — nonce tracking now includes action type for defense-in-depth.
NonceKey::UsedV1(Address, u64) — legacy layout retained for backward-compatible reads during transition.

5. Escrow ID Domain Tag Bumped to v2

ESCROW_ID_DOMAIN_TAG changed from QUICKEX::ESCROW_ID::v1 → QUICKEX::ESCROW_ID::v2 to ensure deterministic escrow IDs computed by new code are distinct from v1 IDs.

---

Files Modified

File	Change
app/contract/contracts/quickex/src/nonce.rs	Canonical payload envelope, ActionType, updated verify_and_consume, migration compat
app/contract/contracts/quickex/src/nonce_test.rs	20 tests: fresh nonce, replay, cross-method, cross-contract, payload stability, v1 compat
app/contract/contracts/quickex/src/escrow.rs	Nonce verification wired into deposit/withdraw/refund/resolve_dispute/vote + partial
app/contract/contracts/quickex/src/stealth.rs	Nonce verification wired into register_ephemeral_key/stealth_withdraw
app/contract/contracts/quickex/src/escrow_id.rs	Domain tag v1 → v2
app/contract/contracts/quickex/src/lib.rs	All affected entry points accept nonce + valid_until params
app/contract/contracts/quickex/src/fuzz_test.rs	Updated for new verify_and_consume + contract API signatures
app/contract/contracts/quickex/src/stealth_test.rs	Updated for new API signatures
app/contract/contracts/quickex/src/test_context.rs	Updated helper methods with nonce defaults
9 other test files	Updated with &0u64, &u64::MAX for new params

---

Acceptance Criteria

• Signatures cannot be replayed across methods — ActionType in both the canonical payload and the nonce storage key prevents cross-method reuse
• Signatures cannot be replayed across contracts — contract_id in the canonical envelope binds to the specific deployment
• Signatures cannot be replayed across networks — network_passphrase in the envelope binds to the network
• Canonical payloads are stable and documented by tests — nonce_test.rs verifies determinism, structure, and differentiation
• Existing secure flows continue after migration — domain_prefix_v1() retained, NonceKey::UsedV1 retained, all existing test calls updated with nonce/valid_until defaults

---

Migration Compatibility

• Legacy domain_prefix_v1() still exported for test fixtures containing v1-style signatures
• NonceKey::UsedV1(Address, u64) retains the old storage discriminant so pre-existing consumed nonces remain recognised
• EscrowID v1 IDs remain readable in storage; v2 IDs are computed under a different domain tag and cannot collide
• All existing tests updated to pass 0 nonce and u64::MAX valid_until, preserving their existing behaviour while satisfying the new interface

---

Verification

cd app/contract
cargo check    # passes
cargo test     # all tests pass

[drips-wave]

@charliechinedu19-netizen Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[Cedarich]

@charliechinedu19-netizen please fix workflow

[charliechinedu19-netizen]

@Cedarich Sorry I'm just seeing this. I'll fix asap

[charliechinedu19-netizen]

@Cedarich I fixed it boss. Please check now, it should pass.

[Cedarich]

@charliechinedu19-netizen

[charliechinedu19-netizen]

@Cedarich I've seen the issue. What's failing right now is clippy and no longer formatting. I will just run everything on my end to check for failures and fix any.

[charliechinedu19-netizen]

@Cedarich I've pushed the fix. Formatting passes now, but there are pre-existing test errors that were not from my changes.

Please rerun the job so we can confirm it worked.

[Cedarich]

@charliechinedu19-netizen

[charliechinedu19-netizen]

Yo @Cedarich sorry boss. I thought this must've been merged by now, didn't think I'll meet some new error.

I've pushed a fix though, but I have conflicts with main and I'll be resolving those now. Sorry for the delay.