Refactor the qtr functions - #168
Open
Moohan wants to merge 4 commits into
Open
Conversation
Tina815
reviewed
Jul 16, 2026
There was a lot of duplication in the code that made it quite complicated / confusing. This PR refactors the duplicated code into a single internal function
Use rlang::caller_call() so the error still 'comes from' the user-facing function.
…ction via as.POSIXlt() Style code (GHA) Document package (GHA)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quarter functions (
qtr(),qtr_end(),qtr_next()andqtr_prev()) shared a large amount of duplicated logic. This PR consolidates the implementation into a single internal helper, reducing code duplication and making the code easier to maintain without changing user-facing behaviour.The refactor also replaces
lubridate::quarter()/lubridate::year()with direct extraction via as.POSIXlt(). Benchmarks across a range of vector sizes and input types showed the new implementation to be consistently 20–30% faster while remaining equivalent to the previous implementation.