Refactor movement sounds and add safety checks#63
Open
DasBander wants to merge 1 commit intoProjectBorealis:mainfrom
Open
Refactor movement sounds and add safety checks#63DasBander wants to merge 1 commit intoProjectBorealis:mainfrom
DasBander wants to merge 1 commit intoProjectBorealis:mainfrom
Conversation
Prevent crashes and reduce copies across movement code: add null checks for DamageEvent.DamageTypeClass and PBPlayerCharacter, guard against divide-by-zero in ShouldCatchAir, and remove several redundant pass-through overrides. Change step/sprint/jump/land sound APIs to return const TArray<TObjectPtr<USoundCue>>& (avoids copying raw pointers) and update PlayMoveSound/PlayJumpSound callsites to handle pointer/references and validate arrays before use. Also change bEdgeFrictionAlwaysWhenCrouching from float to bool in the movement header and clean up related declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent crashes and reduce copies across movement code: add null checks for DamageEvent.DamageTypeClass and PBPlayerCharacter, guard against divide-by-zero in ShouldCatchAir, and remove several redundant pass-through overrides. Change step/sprint/jump/land sound APIs to return const TArray<TObjectPtr>& (avoids copying raw pointers) and update PlayMoveSound/PlayJumpSound callsites to handle pointer/references and validate arrays before use. Also change bEdgeFrictionAlwaysWhenCrouching from float to bool in the movement header and clean up related declarations.