build(windows): change bzip2 and xz-utils to not be shared#7493
build(windows): change bzip2 and xz-utils to not be shared#7493DennisOSRM wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates Conan dependency options to build bzip2 and xz-utils as static (non-shared) libraries instead of shared ones.
Changes:
- Set
bzip2Conan optionsharedtoFalse - Set
xz-utilsConan optionsharedtoFalse
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| self.options["bzip2"].shared = False | ||
| self.options["hwloc"].shared = True | ||
| self.options["xz-utils"].shared = True | ||
| self.options["xz-utils"].shared = False |
There was a problem hiding this comment.
Switching bzip2 and xz-utils to static can change downstream link behavior (especially for consumers expecting shared libs) and may require explicitly linking any transitive system libs those recipes pull in (e.g., dl, pthread, platform-specific libs) depending on Conan profile/toolchain. Please validate that the final binaries still run on a clean runtime environment (no reliance on libbz2.so / liblzma.so) and that packaging/CI images don’t assume the shared libraries are present.
Issue
What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
Please read our documentation on release and version management.
If your PR is still work in progress please attach the relevant label.
Was this change primarily generated using an AI tool?
Kindly make this transparent and disclose which tool / model you have been using.
Please note our contribution guidlines on the use of AI tools.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?