Skip to content

build(windows): change bzip2 and xz-utils to not be shared#7493

Open
DennisOSRM wants to merge 1 commit intomasterfrom
dennis/staticlinkcompression
Open

build(windows): change bzip2 and xz-utils to not be shared#7493
DennisOSRM wants to merge 1 commit intomasterfrom
dennis/staticlinkcompression

Conversation

@DennisOSRM
Copy link
Copy Markdown
Collaborator

Issue

What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.

Please read our documentation on release and version management.
If your PR is still work in progress please attach the relevant label.

Was this change primarily generated using an AI tool?
Kindly make this transparent and disclose which tool / model you have been using.
Please note our contribution guidlines on the use of AI tools.

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

Copilot AI review requested due to automatic review settings April 20, 2026 09:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates Conan dependency options to build bzip2 and xz-utils as static (non-shared) libraries instead of shared ones.

Changes:

  • Set bzip2 Conan option shared to False
  • Set xz-utils Conan option shared to False

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread conanfile.py
Comment on lines +22 to +24
self.options["bzip2"].shared = False
self.options["hwloc"].shared = True
self.options["xz-utils"].shared = True
self.options["xz-utils"].shared = False
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching bzip2 and xz-utils to static can change downstream link behavior (especially for consumers expecting shared libs) and may require explicitly linking any transitive system libs those recipes pull in (e.g., dl, pthread, platform-specific libs) depending on Conan profile/toolchain. Please validate that the final binaries still run on a clean runtime environment (no reliance on libbz2.so / liblzma.so) and that packaging/CI images don’t assume the shared libraries are present.

Copilot uses AI. Check for mistakes.
@DennisOSRM DennisOSRM changed the title Change bzip2 and xz-utils to not be shared build(windows): change bzip2 and xz-utils to not be shared Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants