Add Azure Blob Storage backend#121
Conversation
Adds Azure Blob Storage as a storage backend for snapshots via simpleblob v0.4.0's azure backend. Includes config, docs, Docker Compose local testing with Azurite, and updated test scripts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ptasker
force-pushed
the
azure-storage-only
branch
from
b6cbc03 to
7871f31
Compare
|
@Luit I've isolated just the Azure backend stuff here in this PR. |
|
Sorry for the delay here. There's still a couple of changes I'd prefer to get into simpleblob before we get to updating LS. I won't have much time next week, but hope to get to this the week after. |
|
Sorry to keep you waiting. We've finished up the planned changes in simpleblob now, and released v1.0.0 there. I've also prepared a bit for v1.0.0 of Lightning Stream itself as well, including some backends/s3 Options that were still missing from the I've got a bit of a time restriction now for getting this PR in, though. I tried to expedite the PR by doing the rebase and including a few Options documentation changes. I sadly messed up the go.mod/go.sum merge conflict. Could you please pull in 79471d5 to your branch to restore this? 😅 |
| docker run -w /src --entrypoint '' "$image" /src/test.sh "$@" | ||
| docker run \ | ||
| -v /var/run/docker.sock:/var/run/docker.sock \ | ||
| -w /src --entrypoint '' "$image" /src/test.sh "$@" |
There was a problem hiding this comment.
Could you revert this one, as the ./test.sh doesn't run simpleblob's tests anymore and therefore shouldn't need a docker.sock anymore.
| env *lmdb.Env | ||
| events *events.Events | ||
| hooks *hooks.Hooks | ||
|
|
|
Sorry, was away last week, sounds like we're all good here? |
|
No problem. I found out I could just push to your branch, so I fixed it up and merged the lot. Thanks for your contribution. It's part of the now released version 1.0.0! |
2 participants
Summary
simpleblobv0.4.0'sazurebackendtest.shandtest-in-docker.shto support Azure testingThis is a focused re-submission of #96 addressing @Luit's feedback — GenerationID changes and metrics additions have been removed. Only the storage backend wiring is included.
Test plan
go build ./...to verify clean buildgo test ./...to verify tests passdocker compose upwith Azurite and verify snapshots are written/read from Azure Blob Storage emulatordocs/configuration.mdfor Azure config options