fix(surveys): prevent color hex overflow - #795
Merged
Merged
Conversation
Contributor
posthog-ios Compliance ReportDate: 2026-09-02 04:37:38 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
dustinbyrne
marked this pull request as ready for review
September 2, 2026 04:21
Contributor
|
Reviews (1): Last reviewed commit: "refactor(surveys): clarify color normali..." | Re-trigger Greptile |
ioannisj
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Fixes #794.
Survey appearance colors come from remote config and are passed to
UIColor(hex:). Seven-digit values were expanded beyond 32 bits, while values longer than eight digits remained too wide, causing Swift to trap when narrowing the parsed value toUInt32.This change right-pads seven-digit values with one zero, preserves exactly eight digits, and truncates longer values to their first eight digits before parsing. Existing shorter color formats keep their current behavior.
💚 How did you test it?
make test— 765 tests passedmake testOniOSSimulator— 875 tests passed, including the new regression testmake lint— passed with pre-existing warningspnpm changeset status— recognized the patch changesetmake buildSdk— iOS, macOS, Mac Catalyst, and Swift Package builds passed; the remaining platform builds could not run because the local Xcode installation does not include the tvOS 26.5 runtime📝 Checklist
If releasing new changes
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with the Pi coding agent after the human directed the normalization behavior and discussed the backend reachability. A fresh read-only reviewer found no blockers. The agent session is not linked because it contains a test-project credential.