fix(push): take the core push-open dedupe from posthog-android 3.65.0 and posthog-ios 3.75.0 - #578
Open
turnipdabeets wants to merge 1 commit into
Open
turnipdabeets wants to merge 1 commit into
turnipdabeets wants to merge 1 commit into
Conversation
Contributor
posthog-flutter Compliance ReportDate: 2026-09-15 01:16:28 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
turnipdabeets
marked this pull request as ready for review
September 11, 2026 14:39
Prompt To Fix All With AI### Issue 1
posthog_flutter/android/src/test/kotlin/com/posthog/flutter/AutoCapturedPushOpensTest.kt:12-18
**Tests are not parameterised**
These tests repeat the same setup, remember, and membership checks across separate methods and inline input lists. This violates the repository directive to prefer parameterised tests and works against its OnceAndOnlyOnce rule. Please consolidate the matching, non-matching, and invalid-entry cases into parameterised tests before merging.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(push): key the push-open dedupe on i..." | Re-trigger Greptile |
turnipdabeets
marked this pull request as draft
September 11, 2026 15:09
5 tasks
This was referenced Sep 11, 2026
Open
turnipdabeets
force-pushed
the
fix/push-open-manual-dedupe
branch
from
September 12, 2026 16:26
26b7faf to
47b9f13
Compare
posthog-android 3.65.0 and posthog-ios 3.75.0 count a PostHog notification tap once across the automatic and manual paths, so the plugin no longer needs its own copy of the rule. Raise both floors and document what the window does and does not do.
turnipdabeets
force-pushed
the
fix/push-open-manual-dedupe
branch
from
September 15, 2026 01:11
a9fce8a to
3e2ce3b
Compare
turnipdabeets
marked this pull request as ready for review
September 15, 2026 01:14
|
Reviews (2): Last reviewed commit: "fix(push): take the core push-open dedup..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the push-open deduplication now built into the native SDKs, and drops the plugin-level copy.
posthog-android3.65.0 andposthog-ios3.75.0 count a PostHog notification tap once, whichever path reports it — the SDK's automatic capture or a manualcapturePushNotificationOpened()call. The rule lives at the single choke point every path reaches, so the plugin no longer mirrors it.What changes for developers: nothing to call differently. A manual
capturePushNotificationOpened()for a PostHog-sent push already captured within the last 5 minutes (sameinvocation_idandaction_id) is skipped instead of counted twice. A rerun of the workflow sends a new notification and counts separately. A push from another provider carries nothing to match on, so it is still counted once per report.The Dart doc now also states the limit that follows from this: a manual call cannot enrich an automatic capture. Android's tray intent carries no notification text, so its automatic event has no
$notification_titleor$notification_body, and re-reporting the tap with them is skipped rather than merged.posthog-androidfloorposthog-iosfloorRelated PRs
CI is red until posthog-android 3.65.0 and posthog-ios 3.75.0 are published — the version resolution jobs cannot find them yet. Everything else passes. Both are merged to their default branches and release Monday.