Db v4 move graph folder#2624
Draft
arienandalibi wants to merge 4 commits into
Draft
Conversation
…icate DIRTY_PATH in raphtory-graphql/src/data.rs
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: c62e445 | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
5 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
5 ns/iter (± 0) |
1 ns/iter (± 0) |
5 |
lotr_graph/iterate_exploded_edges |
575887 ns/iter (± 1499) |
285473 ns/iter (± 2920) |
2.02 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
7622943 ns/iter (± 22400) |
1564816 ns/iter (± 35303) |
4.87 |
lotr_graph_window_100/num_nodes |
13 ns/iter (± 0) |
5 ns/iter (± 0) |
2.60 |
lotr_graph_window_100/iterate_exploded_edges |
764360 ns/iter (± 2612) |
325242 ns/iter (± 847) |
2.35 |
lotr_graph_window_100_materialise/materialize |
8064766 ns/iter (± 27034) |
1669150 ns/iter (± 10700) |
4.83 |
lotr_graph_window_10/has_node_existing |
148 ns/iter (± 8) |
62 ns/iter (± 11) |
2.39 |
lotr_graph_window_10/iterate nodes |
31900 ns/iter (± 108) |
11339 ns/iter (± 40) |
2.81 |
lotr_graph_window_10/iterate_exploded_edges |
391512 ns/iter (± 705) |
155788 ns/iter (± 1001) |
2.51 |
lotr_graph_window_10_materialise/materialize |
3526795 ns/iter (± 23030) |
971980 ns/iter (± 4278) |
3.63 |
lotr_graph_subgraph_10pc_materialise/materialize |
1665428 ns/iter (± 14610) |
334634 ns/iter (± 1287) |
4.98 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
152 ns/iter (± 7) |
62 ns/iter (± 14) |
2.45 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
5347 ns/iter (± 95) |
1365 ns/iter (± 3) |
3.92 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1032061 ns/iter (± 5642) |
230399 ns/iter (± 2617) |
4.48 |
lotr_graph_window_50_layered/num_edges_temporal |
151484 ns/iter (± 1317) |
70121 ns/iter (± 7586) |
2.16 |
lotr_graph_window_50_layered/has_node_existing |
435 ns/iter (± 17) |
129 ns/iter (± 12) |
3.37 |
lotr_graph_window_50_layered/iterate nodes |
74555 ns/iter (± 302) |
19308 ns/iter (± 47) |
3.86 |
lotr_graph_window_50_layered/iterate edges |
186708 ns/iter (± 734) |
83616 ns/iter (± 1318) |
2.23 |
lotr_graph_window_50_layered/graph_latest |
79286 ns/iter (± 2379) |
36649 ns/iter (± 916) |
2.16 |
lotr_graph_window_50_layered_materialise/materialize |
31836938 ns/iter (± 150328) |
3488825 ns/iter (± 24948) |
9.13 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
607549 ns/iter (± 3285) |
192686 ns/iter (± 1569) |
3.15 |
lotr_graph_persistent_window_50_layered/has_node_existing |
493 ns/iter (± 328) |
174 ns/iter (± 83) |
2.83 |
lotr_graph_persistent_window_50_layered/iterate nodes |
99505 ns/iter (± 642) |
35886 ns/iter (± 191) |
2.77 |
lotr_graph_persistent_window_50_layered/iterate edges |
172771 ns/iter (± 364) |
84161 ns/iter (± 596) |
2.05 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
4283577 ns/iter (± 18339) |
1659940 ns/iter (± 19402) |
2.58 |
lotr_graph_persistent_window_50_layered/graph_latest |
116214 ns/iter (± 2679) |
57549 ns/iter (± 4809) |
2.02 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
56134142 ns/iter (± 342378) |
5298035 ns/iter (± 147912) |
10.60 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move graph_folder.rs constants (directory and file names regarding exported graphs) out of the raphtory crate and into raphtory-api.
Why are the changes needed?
Following previous changes, we needed access to GRAPH_META_PATH in pometry-storage, where we can't import from raphtory.
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Tests still pass
Are there any further changes required?
No