test(naming): conform every test file and function name to the tests/vetting SPEC - #403
Open
darkclad wants to merge 1 commit into
Open
test(naming): conform every test file and function name to the tests/vetting SPEC#403darkclad wants to merge 1 commit into
darkclad wants to merge 1 commit into
Conversation
…vetting SPEC Waves 2-10 conformed the file names; the function names still carried the legacy vocabulary. Applies SPEC 6.2 to all 616 test functions, finishes the 18 remaining 6.1 file renames, moves helpers to the assert_* prefix, and adds check_test_names.py so the convention is enforced in CI instead of aspirational. gtest 722/722 (517 TEST cases before and after); pytest 84 passed (7 pre-existing Arrow failures need USE_ARROW=ON); both vetting lints green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waves 2-10 conformed the file names; the function names still carried the legacy vocabulary. Applies SPEC 6.2 to all 616 test functions, finishes the 18 remaining 6.1 file renames, moves helpers to the assert_* prefix, and adds check_test_names.py so the convention is enforced in CI instead of aspirational.
gtest 722/722 (517 TEST cases before and after); pytest 84 passed (7 pre-existing Arrow failures need USE_ARROW=ON); both vetting lints green.